revpi/revpi-middleware
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Update interface name from 'picontrol' to 'PiControl'

Browse Source 
Renamed all occurrences of 'picontrol' to 'PiControl' in the D-Bus
interface definitions, method calls, and test cases for consistency and
adherence to naming conventions. This ensures uniformity across the
codebase and resolves potential naming-related issues.
This commit is contained in:
Sven Sager
2025-04-20 12:19:41 +02:00
parent 157b7bd118
commit 865d2ca7a9
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/revpi_middleware/cli_commands/cli_picontrol.py
View File

@@ -38,7 +38,7 @@ def method_reset():
log.debug("D-Bus call of method ResetDriver") log.debug("D-Bus call of method ResetDriver")
simple_call( simple_call(
"ResetDriver", "ResetDriver",
interface=extend_interface("picontrol"), interface=extend_interface("PiControl"),
bus_type=BusType.SESSION if pi.pargs.use_session_bus else BusType.SYSTEM, bus_type=BusType.SESSION if pi.pargs.use_session_bus else BusType.SYSTEM,
) )
log.info("ResetDriver called via D-Bus") log.info("ResetDriver called via D-Bus")
@@ -48,7 +48,7 @@ def method_await_reset(timeout: int = 0):
detected_signal = await_signal( detected_signal = await_signal(
"NotifyDriverReset", "NotifyDriverReset",
timeout, timeout,
extend_interface("picontrol"), extend_interface("PiControl"),
bus_type=BusType.SESSION if pi.pargs.use_session_bus else BusType.SYSTEM, bus_type=BusType.SESSION if pi.pargs.use_session_bus else BusType.SYSTEM,
) )
if detected_signal: if detected_signal:

2
src/revpi_middleware/dbus_middleware1/process_image/interface_picontrol.py
View File

@@ -15,7 +15,7 @@ log = getLogger(__name__)
class InterfacePiControl(DbusInterface): class InterfacePiControl(DbusInterface):
""" """
<node> <node>
<interface name='com.revolutionpi.middleware1.picontrol'> <interface name='com.revolutionpi.middleware1.PiControl'>
<signal name="NotifyDriverReset"> <signal name="NotifyDriverReset">
</signal> </signal>
<method name='ResetDriver'> <method name='ResetDriver'>

4
tests/dbus_middleware1/process_image/test_interface_picontrol.py
View File

@@ -18,7 +18,7 @@ class TestObjectPicontrol(TestBusProvider):
def test_reset_driver(self): def test_reset_driver(self):
simple_call( simple_call(
"ResetDriver", "ResetDriver",
interface=extend_interface("picontrol"), interface=extend_interface("PiControl"),
bus_type=BusType.SESSION, bus_type=BusType.SESSION,
) )
ioctl_call = IOCTL_QUEUE.get(timeout=2.0) ioctl_call = IOCTL_QUEUE.get(timeout=2.0)
@@ -37,7 +37,7 @@ class TestObjectPicontrol(TestBusProvider):
result = await_signal( result = await_signal(
"NotifyDriverReset", "NotifyDriverReset",
timeout, timeout,
extend_interface("picontrol"), extend_interface("PiControl"),
bus_type=BusType.SESSION, bus_type=BusType.SESSION,
) )
self.assertTrue(result) self.assertTrue(result)