From 393ec93649ee4b658a8a4c17c57269d3ea41cca8 Mon Sep 17 00:00:00 2001 From: Sven Sager Date: Fri, 7 Aug 2026 06:09:51 +0200 Subject: [PATCH] fix: Endlessloop during revpipyload activation on remote host RevPi Commander can activate the `revpipyload` service with an SSH connection on the remote host and starts a new connection. If the activation of the service failed, the user was in an endless loop and had to end the process via the operating system. Signed-off-by: Sven Sager --- src/revpicommander/revpicommander.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/revpicommander/revpicommander.py b/src/revpicommander/revpicommander.py index f9ee948..3dced74 100644 --- a/src/revpicommander/revpicommander.py +++ b/src/revpicommander/revpicommander.py @@ -129,7 +129,8 @@ class RevPiCommander(QtWidgets.QMainWindow, Ui_win_revpicommander): # region # REGION: Connection management @QtCore.pyqtSlot(str, str, ConnectionFail, RevPiSettings) - def on_cm_connect_error(self, title: str, text: str, fail_code: ConnectionFail, revpi_settings: RevPiSettings): + def on_cm_connect_error(self, title: str, text: str, fail_code: ConnectionFail, + revpi_settings: RevPiSettings): """ Slot to get information of pyload_connect connection errors. @@ -138,7 +139,8 @@ class RevPiCommander(QtWidgets.QMainWindow, Ui_win_revpicommander): :param fail_code: Type of error :param revpi_settings: Settings of the revpi with the error """ - if fail_code is ConnectionFail.NO_XML_RPC_VIA_TUNNEL: + if (fail_code is ConnectionFail.NO_XML_RPC_VIA_TUNNEL + and not getattr(revpi_settings, "ssh_enable_revpipyload", False)): # If RevPiPyLoad is not running, we can try to activate it via ssh QtWidgets.QMessageBox.information( self, self.tr("Information"), self.tr(