revpi/revpicommander
1
0
Fork 0
mirror of https://github.com/naruxde/revpicommander.git synced 2026-08-16 13:47:04 +02:00
Code Issues Packages Releases Wiki Activity

fix: Handle sudo authentication failure during RevPiPyLoad activation

Browse Source 
Improve logic to handle scenarios where sudo requires a password for
activating RevPiPyLoad, including user notification and error handling.

Signed-off-by: Sven Sager <akira@narux.de>
This commit is contained in:
akira
2026-08-07 07:11:00 +02:00
parent e7b5848664
commit 86c644e830
1 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/revpicommander/helper.py
+28 -1
View File
@@ -413,7 +413,34 @@ class ConnectionManager(QtCore.QThread):
log.warning(f"Could not check remote config for unix socket: {e}") log.warning(f"Could not check remote config for unix socket: {e}")
if getattr(revpi_settings, "ssh_enable_revpipyload", False): if getattr(revpi_settings, "ssh_enable_revpipyload", False):
ssh_tunnel_server.send_cmd("sudo systemctl enable --now revpipyload") cmd_activate_pyload = "systemctl enable --now revpipyload"
# Test sudo requires password authentication
_, _, exit_code = ssh_tunnel_server.send_cmd("sudo -n true")
if exit_code == 0:
# No password required
ssh_tunnel_server.send_cmd(f"sudo {cmd_activate_pyload}")
else:
# Execute command with sudo password
_, _, exit_code = ssh_tunnel_server.send_cmd(
f"sudo -S {cmd_activate_pyload}",
stdin=ssh_pass,
)
if exit_code != 0:
log.error(
"Sudo authentification failed for user %s",
revpi_settings.ssh_user,
)
self.connect_error.emit(
self.tr("Error"), self.tr(
"Can not activate RevPiPyLoad on remote RevPi.\n"
f"Sudo authentification failed for user {revpi_settings.ssh_user}. "
"Please activate RevPiPyLoad manually via Cockpit or CLI."
),
ConnectionFail.NO_XML_RPC_VIA_TUNNEL,
revpi_settings,
)
return False
except asyncssh.PermissionDenied: except asyncssh.PermissionDenied:
self.connect_error.emit( self.connect_error.emit(